Fix for Useless assignment to local variable#304
Merged
samsmithnz merged 1 commit intomainfrom Dec 5, 2025
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Pull Request Test Coverage Report for Build 19963984949Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unnecessary assignment to the local variable
resultwithin theCountMandMsInACylinderWithNullUnitTestshould be removed. Instead, simply invokeCalculator.CountMandMs(unit, height, radius);on line 332, as the test's purpose is solely to ensure that calling this method with a null unit throws (and catches) an exception. No assertion or usage ofresultis needed. Only the single line (332) should be changed; no variable declaration or other changes are necessary since the variable is declared and initialized in one line.Suggested fixes powered by Copilot Autofix. Review carefully before merging.